docs: Replace slack links #9919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9919 +/- ##
=======================================
Coverage 59.18% 59.18%
=======================================
Files 751 751
Lines 104454 104454
Branches 3598 3597 -1
=======================================
Hits 61824 61824
Misses 42498 42498
Partials 132 132
Flags with carried forward coverage won't be shown. Click here to find out more. |
molinamelendezj
approved these changes
Sep 11, 2024
|
@molinamelendezj Some tests didn't pass. Is it still ok to merge? |
|
I'd love to see all green. you can try a rerun. but I don't see this change being the cause. these are all static doc changes. I question if it should be even running these tests. We might need to look into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the tracking Slack links with static links, because the tracking links keep expiring after a certain amount of time or number of clicks, and therefore don't work.